Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENGINES: Change mac resource fork file detection to use the file cache #2458

Closed
wants to merge 1 commit into from
Closed

ENGINES: Change mac resource fork file detection to use the file cache #2458

wants to merge 1 commit into from

Commits on Sep 12, 2020

  1. ENGINES: Change mac resource fork file detection to use the file cache 

    Common::MacResMan is now able to open files from a specified
Common::Archive. This is a bit hacky as dynamic_cast is used to break
the Archive encapsulation to retreive the underlying FSNode. It should
however be more correct than the previous code that assumed files were
at the root of the currently running game's path.

AdvancedDetector constructs a Common::Archive from its FileMap based
filesystem cache and uses it to detect the mac resource fork files.

This cuts the time it takes to run the detection code with all the
engines enabled as dynamic plugins on the 3DS to 30 s from 280 s.
    @bgK
    bgK committed Sep 12, 2020
    Copy the full SHA
    7ef13ae View commit details
    Browse the repository at this point in the history