GUI: Fix #11767 - STARK: The Longest Journey - random text replaced with ... #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tried it, it definitely fixes the bug in TLJ, good work! No idea if it introduces any problems in other games (only quickly started a random SCUMM game and didn't notice anything wrong) but so far this looks good to me. |
GeorgeSapkin
force-pushed
the
fix-stark-font
branch
from
d2e5a68
to
34a89e8
Compare
GeorgeSapkin
changed the title
This is an attempt to fix ellipsifying of text in STARK by changing width and bounding box calculation discrepancy in recently introduced handleEllipsis() and getBoundingBoxImpl().
GeorgeSapkin
force-pushed
the
fix-stark-font
branch
from
34a89e8
to
6c42908
Compare
|
Fixed by eef527e |
|
@aquadran why is your solution preferable? |
|
@GeorgeSapkin because you changed the behaviour of text wrapping for other 9 engines and our GUI. :) |
|
@sev- that I fully understand. But did it actually cause any regressions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix ellipsifying of text in STARK by changing width and bounding box calculation discrepancy in recently introduced
handleEllipsis()andgetBoundingBoxImpl().I haven't dug too deep so this probably makes no sense. Only tested in STARK so far.