Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix #11767 - STARK: The Longest Journey - random text replaced with ... #2530

Closed
wants to merge 1 commit into from

Conversation

@GeorgeSapkin
Copy link

@GeorgeSapkin GeorgeSapkin commented Oct 15, 2020

This is an attempt to fix ellipsifying of text in STARK by changing width and bounding box calculation discrepancy in recently introduced handleEllipsis() and getBoundingBoxImpl().

I haven't dug too deep so this probably makes no sense. Only tested in STARK so far.

@chrisis123
Copy link

@chrisis123 chrisis123 commented Oct 15, 2020

Just tried it, it definitely fixes the bug in TLJ, good work!

No idea if it introduces any problems in other games (only quickly started a random SCUMM game and didn't notice anything wrong) but so far this looks good to me.

@GeorgeSapkin GeorgeSapkin force-pushed the GeorgeSapkin:fix-stark-font branch from d2e5a68 to 34a89e8 Oct 15, 2020
@GeorgeSapkin GeorgeSapkin changed the title GUI: Fix #11767 GUI: Fix #11767 - STARK: The Longest Journey - random text replaced with ... Oct 16, 2020
@aquadran aquadran requested a review from sev- Oct 16, 2020
This is an attempt to fix ellipsifying of text in STARK by changing
width and bounding box calculation discrepancy in recently introduced
handleEllipsis() and getBoundingBoxImpl().
@GeorgeSapkin GeorgeSapkin force-pushed the GeorgeSapkin:fix-stark-font branch from 34a89e8 to 6c42908 Oct 16, 2020
@aquadran
Copy link
Member

@aquadran aquadran commented Oct 16, 2020

Fixed by eef527e

@aquadran aquadran closed this Oct 16, 2020
@GeorgeSapkin
Copy link
Author

@GeorgeSapkin GeorgeSapkin commented Oct 16, 2020

@aquadran why is your solution preferable?

@sev-
Copy link
Member

@sev- sev- commented Oct 16, 2020

@GeorgeSapkin because you changed the behaviour of text wrapping for other 9 engines and our GUI. :)

@GeorgeSapkin
Copy link
Author

@GeorgeSapkin GeorgeSapkin commented Oct 16, 2020

@sev- that I fully understand. But did it actually cause any regressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.