CREATE_PROJECT: fixed cmake generator #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #e1ff39 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
I ran into similar issues when I played around with create_project. +1 from me. |
mgerhardy
force-pushed
the
pr/create-project-cmake-pkgconfig
branch
2 times, most recently
from
7bf2a35
to
ead5e04
Compare
|
With the latest commit I'm now able to not only configure the build system - but also compile and link the binary. But There are also no shared objects created. So I suppose there is some define missing here? |
mgerhardy
force-pushed
the
pr/create-project-cmake-pkgconfig
branch
from
5f2c18f
to
88e61ea
Compare
|
This also fixes some missing defines since the detection plugin rework. |
mgerhardy
force-pushed
the
pr/create-project-cmake-pkgconfig
branch
from
e01e2d0
to
32c6db4
Compare
|
Attached a generated cmake script |
mgerhardy
changed the title
mgerhardy
force-pushed
the
pr/create-project-cmake-pkgconfig
branch
from
3645c3b
to
c851268
Compare
* Support for pkg-config was added * Shortened the CMakeLists.txt by more than 4000 lines * Added macro for feature detection * Configure stage is reporting missing libs as error now (they were reported as compile errors during the build before) * Link the scummvm-detection lib (this was missing before) * Added missing defines like DETECTION_STATIC and USE_SDL2 * Group impl and header files in src file list to shorten the cmake script * Unified indention for generated script
mgerhardy
force-pushed
the
pr/create-project-cmake-pkgconfig
branch
from
c851268
to
e1ff39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these patches I'm now able to configure, compile and link with cmake
DETECTION_STATICandUSE_SDL2CMakeLists.txtto.gitignore