Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
SCUMM: Multi-font for Korean fan translated games #2606
This PR is part of scummvm-kor merge project.
It adds the ability to load and use multiple external Korean fonts to match the original look.
On a separate note, I intend to refactor CJK text rendering to use Graphics::Font*.
DeepCode's analysis on #956e70 found:
The new code seems to be well separated from the existing code. I don't see any issues.
Rendering through the CharsetRendererTownsV3 is a bit ugly. And half of the methods get redirected to CharsetRendererV3 anyway. And the actual MI2 FM-Towns version doesn't even use CharsetRendererTownsV3 (since it isn't Scumm3; it uses CharsetRendererClassic). But that's just nitpicking. We can still check after the merge whether it makes sense to come up with a new CharsetRenderer subclass...