SCUMM: Multi-font for Korean fan translated games #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #956e70 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
- use snprintf() instead of sprintf()
|
The new code seems to be well separated from the existing code. I don't see any issues. Rendering through the CharsetRendererTownsV3 is a bit ugly. And half of the methods get redirected to CharsetRendererV3 anyway. And the actual MI2 FM-Towns version doesn't even use CharsetRendererTownsV3 (since it isn't Scumm3; it uses CharsetRendererClassic). But that's just nitpicking. We can still check after the merge whether it makes sense to come up with a new CharsetRenderer subclass... |
|
Thanks, all is nice and clean. I'll do the occasional formatting fixes in-tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of scummvm-kor merge project.
It adds the ability to load and use multiple external Korean fonts to match the original look.
On a separate note, I intend to refactor CJK text rendering to use Graphics::Font*.
Tested with: