OpenGL: Fix warning for hidden overladed virtual saveScreenshot() function #2924
This reverts commit 0f118d0.
Building for Android (OpenGL) had noisy warning for hiding overloaded virtual function Added a dummy implementation in OpenGLGraphics manager, and also for OpenGLSdlGraphicsManager it now explicitly calls the SdlGraphicsManager implementation for the void argument signature.
Indeed it fixes the warning and it's cleaner.
Still I don't think this addresses the mess/confusion with the two signatures and why we are keeping them separate in this manner, providing implementations for one and not the other, when one (the one with the file argument) can basically use the other (no argument signature) (or the other way around) in every (?) case.
That's rather the other way around. The one without argument can call the one with argument passing the default path for a new screenshot file. The issue is that currently this "default path" is backend-dependent. In the SDL backend you have
The main issue here is that the
So I agree that this could probably be cleaned. But I don't see an obvious way to do it.
Yes, that's correct. I've kind of rethought that sentence (hence the edit) and the typical approach is what you describe.
I completely understand. For now, this PR will do.