TINSEL: Add detection for Discworld 1 PSX Ger/Jap PSX versions #3086
Conversation
|
Files need to be extracted/split correctly from DISCWLD.LFD/DISCWLD.LFI. The attached QuickBMS script can be used on the German and Japanese CDs to extract the data, or could be used to inform handling the LFD/LFI files directly in ScummVM. The QuickBMS script mention in the above request ticket isn't quite right for the Discworld 1 files, so I revised it. (Instead of an OFFSET, that field is an INDEX of 2KB data chucks, so apart from the first file, the available |
|
Overall, the changes to the detection entries look OK. Regarding the checks for file existence, you can use the static method Common::File::exists(), instead of needlessly initializing TinselFile |
|
Please, rename the commit in accordance with our guidelines (https://wiki.scummvm.org/index.php?title=Commit_Guidelines) e.g. to something like "TINSEL: Add detection for Discworld 1 PSX Ger/Jap PSX versions" |
Follow up on: https://bugs.scummvm.org/ticket/11368 Adds detection for German Playstation version. Also corrects detection of Japanese Playstation version. Files need to be extracted/split correctly from DISCWLD.LFD/DISCWLD.LFI. I will attach a QuickBMS script to the PR, which can be used on the German and Japanese CDs to extract the data, or could be used to inform handling the LFD/LFI files directly in ScummVM. The QuickBMS script mention in the above request ticket isn't quite right for the Discworld 1 files. getSampleIndex and getSampleFile in tinsel.cpp now fallback to ENGLISH files if they fail to find (e.g.) GERMAN.IDX. This was an easy way to add support for the PSX German CD, without breaking the German DOS CD, Japanese PSX CD etc. The German PSX version should be as compatible as the English PSX version. The Japanese PSX version subtitles are not supported, and cause ScummVM to crash when you first try to hover over an object. However, you can view the intro cutscene, and hear the audio.
eddebaby
force-pushed
the
discworld_detect_psx_ger_and_jpn
branch
from
2ebae7d
to
37e2548
Compare
eddebaby
changed the title
When testing if the chosen <LANG>.IDX file exists - use Common::File::exists() instead of initialising a new TinselFile f, and using f.open
|
Thanks for your work! Merging |
Follow up on: https://bugs.scummvm.org/ticket/11368
Adds detection for German Playstation version.
Also corrects detection of Japanese Playstation version.
getSampleIndex and getSampleFile in tinsel.cpp now fallback to ENGLISH files if they fail to find (e.g.) GERMAN.IDX.
This was an easy way to add support for the PSX German CD, without breaking the German DOS CD, Japanese PSX CD etc.
The German PSX version should be as compatible as the English PSX version.
The Japanese PSX version subtitles are not supported, and cause ScummVM to crash when you first try to hover over an object. However, you can view the intro cutscene, and hear the audio.
__
Edit: I only marked as draft as this is my first submission, the code should be ready as is.