Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BURIED: Fix missing research points (bug 12881) #3337

Merged
merged 2 commits into from Sep 7, 2021

Conversation

@eriktorbjorn
Copy link
Member

@eriktorbjorn eriktorbjorn commented Sep 2, 2021

This should fix the missing research points described in https://bugs.scummvm.org/ticket/12881

Basically, the bug boiled down to the points only being awarded when pressing the "previous" button. And that would never take you to the pages that awarded the points.

Note that since I've never gotten around to playing the game, it's quite difficult for me to tell if I've accidentally mixed up anything. I'd be grateful if someone more familiar with the game could test it.

eriktorbjorn added 2 commits Sep 3, 2021
The positions of the previous and next button had been mixed up. The
previous button is left of the next button, not the other way around.

This meant you could only be awarded points when pressing the previous
button, and since you would then step away from the page that awards
point that did not work.

Since the buttons worked in other respects, the id for the previous and
next pages must also have been similarly mixed up. This too should be
fixed now.
The Agent 3 information and profile research points were awarded when
pressing the "next" button, so they were never awarded. Award them when
hitting a hotspot instead.
@Thunderforge
Copy link
Contributor

@Thunderforge Thunderforge commented Sep 7, 2021

I've tested it out and it looks good to me.

I don't see any unexpected side effects either, so I'm in favor of merging (and backporting to 2.3.x if possible).

@Thunderforge
Copy link
Contributor

@Thunderforge Thunderforge commented Sep 7, 2021

For completeness, here are screenshots showing that the bug is fixed.

Following reproduction instructions from the bug report

Looking at the correct screens in Biochip - Files and then dying shows a Research Bonus of 300, as expected.

Following PR Instructions

Full Game

A complete 15000 out of 15000 points can now be achieved.

100% Completion

@sev-
Copy link
Member

@sev- sev- commented Sep 7, 2021

Excellent, thank you! I will also backport it

@sev- sev- merged commit 0e7c8ce into scummvm:master Sep 7, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants