BURIED: Fix missing research points (bug 12881) #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2021 08:23
The positions of the previous and next button had been mixed up. The previous button is left of the next button, not the other way around. This meant you could only be awarded points when pressing the previous button, and since you would then step away from the page that awards point that did not work. Since the buttons worked in other respects, the id for the previous and next pages must also have been similarly mixed up. This too should be fixed now.
The Agent 3 information and profile research points were awarded when pressing the "next" button, so they were never awarded. Award them when hitting a hotspot instead.
eriktorbjorn
force-pushed
the
buried-fix-12881
branch
from
f238c2b
to
d510631
Compare
|
I've tested it out and it looks good to me. I don't see any unexpected side effects either, so I'm in favor of merging (and backporting to 2.3.x if possible). |
|
For completeness, here are screenshots showing that the bug is fixed. Following reproduction instructions from the bug reportLooking at the correct screens in Biochip - Files and then dying shows a Research Bonus of 300, as expected.
Full GameA complete 15000 out of 15000 points can now be achieved.
|
|
Excellent, thank you! I will also backport it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the missing research points described in https://bugs.scummvm.org/ticket/12881
Basically, the bug boiled down to the points only being awarded when pressing the "previous" button. And that would never take you to the pages that awarded the points.
Note that since I've never gotten around to playing the game, it's quite difficult for me to tell if I've accidentally mixed up anything. I'd be grateful if someone more familiar with the game could test it.