NEVERHOOD: Possible fix for bug #12930 (crash on exit) #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's consistent with how sounds 1 and 2 are handled, and seems to fix bug #12930, where the game can crash on exit otherwise.
|
This is indeed a correct fix, as sounds in this category were not properly cleared. Your implementation follows the handling done for the other two categories. Thanks for spotting and fixing this! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix I suggested on https://bugs.scummvm.org/ticket/12930
I don't know if it's correct - I never got any feedback on it - but it does seem to fix the game crashing on exit for me. If I'm right, it was trying to keep playing a sound after the audio data for it had been freed. With the change, sound 3 is handled the same way as sounds 1 and 2, i.e. stopped first.