TWINE: fixes from original source code #3633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
4 times, most recently
from
603a078
to
fcd9ab1
Compare
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
7 times, most recently
from
dee5cd7
to
e0dee84
Compare
|
@mgerhardy is there a reason to keep this PR open? A PR can be opened once all the changes are in a good state to be reviewed and merged. |
|
I just thought it might increase visibility and the chance that someone jumps in to help testing the changes. If I should close it, just let me know. |
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
from
c47bed3
to
2df3859
Compare
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
2 times, most recently
from
728f488
to
eead129
Compare
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
3 times, most recently
from
4dc4e7a
to
d798496
Compare
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
from
d798496
to
b4f9e10
Compare
the modification of the processActor values from checkActorCollisionWithBricks and checkHeroCollisionWithBricks were lost. The bug was that you could move crates into walls in the 'sokoban'-scene (scene 35). See https://bugs.scummvm.org/ticket/13177 This also renamed a few members to the one given in the original sources and marks some methods with the original sources function names for easier tracking This re-introduced the tank bug in scene 63
mgerhardy
force-pushed
the
pr/twine-original-source-code-fixes
branch
from
b4f9e10
to
89813d4
Compare
|
This is now bitrot big time |
|
Why did you close it? I thought it has a set of proper changes, just needs to be rebased. Or is there a misunderstanding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to sync our code base with the original code base that was released recently.
A few errors were found, but they still need testing.
change_scene 63) (savegame at https://bugs.scummvm.org/ticket/13168#no1)change_scene 35)