Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWINE: fixes from original source code #3633

Closed

Conversation

mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented Dec 28, 2021

This tries to sync our code base with the original code base that was released recently.

A few errors were found, but they still need testing.

@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch 4 times, most recently from 603a078 to fcd9ab1 Compare Dec 31, 2021
@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch 7 times, most recently from dee5cd7 to e0dee84 Compare Feb 15, 2022
@bluegr
Copy link
Member

@bluegr bluegr commented Apr 22, 2022

@mgerhardy is there a reason to keep this PR open? A PR can be opened once all the changes are in a good state to be reviewed and merged.

@mgerhardy
Copy link
Contributor Author

@mgerhardy mgerhardy commented Apr 30, 2022

I just thought it might increase visibility and the chance that someone jumps in to help testing the changes. If I should close it, just let me know.

@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch from c47bed3 to 2df3859 Compare May 28, 2022
@mgerhardy mgerhardy marked this pull request as ready for review May 28, 2022
@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch 2 times, most recently from 728f488 to eead129 Compare Jun 1, 2022
@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch 3 times, most recently from 4dc4e7a to d798496 Compare Jun 11, 2022
@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch from d798496 to b4f9e10 Compare Jun 11, 2022
the modification of the processActor values from checkActorCollisionWithBricks and checkHeroCollisionWithBricks were
lost. The bug was that you could move crates into walls in the 'sokoban'-scene (scene 35).

See https://bugs.scummvm.org/ticket/13177

This also renamed a few members to the one given in the original sources and marks some methods with the original
sources function names for easier tracking

This re-introduced the tank bug in scene 63
@mgerhardy mgerhardy force-pushed the pr/twine-original-source-code-fixes branch from b4f9e10 to 89813d4 Compare Jun 11, 2022
@sev-
Copy link
Member

@sev- sev- commented Jun 12, 2022

This is now bitrot big time

@mgerhardy mgerhardy closed this Jun 12, 2022
@sev-
Copy link
Member

@sev- sev- commented Jun 12, 2022

Why did you close it? I thought it has a set of proper changes, just needs to be rebased.

Or is there a misunderstanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants