ALL: Rework OpenGL detection #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
force-pushed
the
rework-gl
branch
from
75afcf2
to
da2ad88
Compare
aquadran
reviewed
Jan 7, 2022
aquadran
reviewed
Jan 7, 2022
lephilousophe
force-pushed
the
rework-gl
branch
from
8628e01
to
463e748
Compare
aquadran
reviewed
Jan 16, 2022
Replace it with USE_FORCED_GLES2
lephilousophe
force-pushed
the
rework-gl
branch
from
463e748
to
f5f5669
Compare
With GLAD it's not needed anymore to link against OpenGL libraries. As configure knows better whether a platform supports GLAD, detection is moved here. To allow platforms where OpenGL should be linked at build time, the tests are kept. Android uses them for now. The OpenGL for Games was completely decoupled from the OpenGL for 2D engines. This not the case anymore.
lephilousophe
force-pushed
the
rework-gl
branch
from
f5f5669
to
0bd568e
Compare
|
I did some builds on platforms supported by buildbot and GLAD gets included only when necessary so this seems to be OK. |
aquadran
approved these changes
Jan 17, 2022
bluegr
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of GLAD, OpenGL libraries don't need to be linked with ScummVM for those platforms.
In addition, GLAD support is known at configure step by knowing the platform to configure.
This PR also tries to merge two configure paths: the one for 2D engines, and the one for 3D engines.
It builds correctly on Linux and Android. No other tests have been done yet.
In addition, create_project still has a USE_GLES2 define and no USE_GLES_MODE.