PARALLACTION: Partially fix stuck verbs bug in Nippon Safes (bug #4815) #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses following issue: https://bugs.scummvm.org/ticket/4815 The bug report details multiple instances of explanation verbs staying on the screen when they shouldn't be. The one I managed to fix was the one at the Eternal Rest Hotel. This video shows a simple before and after: https://drive.google.com/file/d/1U8hKCHt1-78LaAgYNM9fFk0kqKdwJ9iH/view?usp=sharing
|
Nice :-) |
|
hc8756: This looks reasonable and self contained to PARALLACTION engine. However, we try to avoid links in commit messages to file sharing services since they will tend to break quickly. Will merge manually, rewriting commit message to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses following issue: https://bugs.scummvm.org/ticket/4815
The bug report details multiple instances of explanation verbs staying on the screen when they shouldn't. The one I managed to fix was the one at the Eternal Rest Hotel. This video shows a simple before and after: https://drive.google.com/file/d/1U8hKCHt1-78LaAgYNM9fFk0kqKdwJ9iH/view?usp=sharing