Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: fix palette regression #4037

Merged
merged 1 commit into from Jun 23, 2022
Merged

Conversation

mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Jun 23, 2022

#3979 introduced a fix for fetching the palette. However, it misinterpreted the number as an unsigned int instead of a signed int, leading to incorrect palettes on certain other games.

@einstein95 suggested this. I confirmed that via reading as a signed int, Japan Art Today 07 is fixed while The Seven Colours retains the correct palette from #3979.

Fixes https://bugs.scummvm.org/ticket/13615.

7f0d693 introduced a fix for
fetching the palette. However, it misinterpreted the number as an
unsigned int instead of a signed int, leading to incorrect palettes
on certain other games.
@sev-
Copy link
Member

@sev- sev- commented Jun 23, 2022

Thank you!

@sev- sev- merged commit 6f78d0e into scummvm:master Jun 23, 2022
8 checks passed
@mistydemeo mistydemeo deleted the director_re_fix_palette branch Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants