Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDEO: Fix QuickTime regression with mediaTime and dithering #4156

Merged
merged 1 commit into from Aug 4, 2022

Commits on Aug 4, 2022

  1. VIDEO: Fix QuickTime regression with mediaTime and dithering

    Fixes an error when playing a QuickTime video that has a mediaTime set
    on its first edit. This was caused by mediaTime changes in:
    ef184a6
    
    Those changes buffered frames during initialization so that the keyframe
    and other frames don't play instead of the intended start frame that
    mediaTime specifies. My mistake was that decoding isn't allowed during
    VideoDecoder::loadStream(); VideoDecoder::setDitheringPalette() requires
    that no frames have been decoded yet, and at least Director and Mohawk
    call that.
    
    Now the initial mediaTime buffering is delayed until the first decode.
    
    Fixes bug #13479 where certain Myst videos error.
    Fixes the opening movie in the Director game Chop Suey.
    sluicebox committed Aug 4, 2022
    Copy the full SHA
    9175671 View commit details
    Browse the repository at this point in the history