Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Show user-provided names in grid widget #4185

Closed
wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 14, 2022

If the description is Some Game (DOS/English), then show the original title
(Some Game), since the DOS/English is expressed using icons. But in case it
has been changed by the user, show it as it is.

If the description is Some Game (DOS/English), then show the original title
(Some Game), since the DOS/English is expressed using icons. But in case it
has been changed by the user, show it as it is.
@orgads orgads requested a review from SupSuper Aug 14, 2022
@SupSuper
Copy link
Contributor

SupSuper commented Aug 15, 2022

This won't work since not every game has (DOS/English) in the built-in description, and some games have ( in the title. That's why we stopped hacking around with (
The only clear way to fix this is to have a clear indicator of what is "user description" and what is "detection description" instead of trying to guess. For example we could default game entries to an empty description, which is filled in by the GUI, until the user customizes it.

@sev-
Copy link
Member

sev- commented Sep 18, 2022

I think the best approach here would be swapping game title and tooltip. E.g. show the user-provided name as default and game title in the tooltop.

@sev- sev- closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants