Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS2: Pull request to branch 1.6.0 for latest PS2 code #430

Merged
merged 31 commits into from Apr 28, 2014

Conversation

sunmax
Copy link
Contributor

@sunmax sunmax commented Jan 25, 2014

Hi there Team,

here comes the latest & greatest PS2 ScummVM ;-)

Changelog:

  • fixed all stack issues (now PS2 build is cleanly gdb- & gprof-friendly)
  • added [PlayStation2] section to scummvm.ini
  • configurable: TV standard, gfx resolution, hdd partition
  • modular driver loading (you can disable unused ones in [PlayStation2]
  • support for latest PS2 SDK on github
  • dynamic plugins enabled by default
  • improved "configure" support
  • code cleanup and sane casting
  • see log for all changes ;-)

Please note, that we now default to latest SDK, so we'll need that for Buildbot too or daily build will fail.

You can select old SDK by undef NEW_PS2SDK

Let me know if you have any questions or suggestions.

Thanks,
-max

     <1555> alpha is otherwise broken with classic theme
TODO: investigate stack corruption due to double free
TODO: review modules loader fallback logic
@ghost ghost assigned sev- Jan 25, 2014
@sev-
Copy link
Member

sev- commented Apr 28, 2014

Merging for the sake of debugging convenience and completeness.

sev- added a commit that referenced this pull request Apr 28, 2014
PS2: Pull request to branch 1.6.0 for latest PS2 code
@sev- sev- merged commit 2d93e78 into scummvm:branch-1-6-0 Apr 28, 2014
@digitall
Copy link
Member

@sev- : I think the Pull Requests for PS2 against the older release branches are due to a suggestion of mine. I said that it would be useful for porters who miss releases to "fill in" the missing releases later on.

This means that users who report a regression bug can do a "gross bisection" of the older releases without saying .e.g. "Well, it worked in v1.4.1, and it is now broken in v1.6.0 .... pity we don't have any releases between, must have got broken somewhere in there" :/

This is especially important for embedded type builds with tricky toolchains to bring up as finding a user with the hardware, the game, the technical capability to do a build and bisection and inclination is thus pretty difficult...

At least with the releases filled in, we get a better "Oh, it was between v1.4.1 and v1.5.0"... which is much narrower range to search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants