GUI: Change wording of "return to launcher" checkbox

[tag2015]

This is a minor change to the "return to launcher" checkbox that, as indicated in bugreport #12839, is not supported by all engines and could confuse users.
Since implementing that feature is not necessarily trivial and indicating whether the feature is supported or not per-engine
seems redundant, I simply added a generic "not supported by all games" to the tooltip, which should be enough for most
users.

This is just a proposal, feedback is appreciated :)

[criezy]

The change of wording looks good to me.

[lotharsm]

Looks good to me as well. Thank you!

[sev-]

Why was this changed? Do you know the history behind the word "always"?

There are three ways to leave a game:

1, User quits the game with the in-game interface
2. User presses the "close window" button on the ScummVM window
3. User presses the quit key combination like Alt+X or Cmd+Q
This setting makes all three return to the launcher. Your wording loses that.

What is the reasoning behind changing this wording?

[sev-]

After reading the bugreport, I am kind of puzzled about how and why this thing is addressing it.

The Director engine is clearly missing the RTL feature, e.g. it is not supported and never was. Perhaps, now with the work of @rvanlaar, it could be reverted.

The proper fix, if you want to do it, is exposing that option via GUIO or somehow cache it, so the checkbox is disabled when the engine is not supporting kSupportsReturnToLauncher. NOT changing the legitimately named option.

[sev-]

@tag2015 with this information, perhaps you could come up with better wording explaining the situation to the end users.

But in its current form, I think, this better be reverted or amended.

[tag2015]

My reasoning is explained in my first post, so I won't repeat.
About the fact that "always" indicates three different things, I think that it's implicit that a "return to launcher" checkbox
indicates such a behavior in all possible "exits". On the other hand, "always" could also be interpreted as "in any possible situation", which is not correct since not all engines (current or future) support such a feature.

[criezy]

I agree with @tag2015 here. For me ‘Always’ was ambiguous and was likely to be understood as meaning for all games. And I don’t think it was necessary. “Return to the launcher when quitting a game” does convey sufficiently the meaning that it does not depend on how we quit the game in my opinion.

There are three five ways to leave a game:
1, User quits the game with the in-game interface
2. User presses the "close window" button on the ScummVM window
3. User presses the quit key combination like Alt+X or Cmd+Q.

4. User presses the "Quit" button from the Global Main Menu
5. User presses the "Return to Launcher" button from the Global Main Menu

From what I remember, the fifth one was actually the reason to include "Always" in the initial wording, as opposed to "Sometimes" depending on which of the 5 options was used. But I am really not sure it is needed. This seems obvious to me.

[lotharsm]

Hi all, I think that the "Always" part was indeed misleading here, which is why approved this PR.

However, I really didn't think about declaring support for it in the engines themselves would be a nicer option :/

[criezy]

I don't really understand how declaring support for it in the engines would help.
We already have kSupportsReturnToLauncher, and this is already used in the GMM to ignore the setting.
The setting itself is only global and is not present in the Game Options, so I fail to see how it could be useful to know that a specific engine supports it or not.

[sev-]

My point was to query the metaengine and if the engine is not supporting the RTL, then disable the checkbox

[lotharsm]

Hm, but this checkbox is in the global settings, isn't it? So even if we know that a game or engine doesn't support it, there is no way to disable it in the global settings, unless we want to completely remove this settings as soon as one game isn't compatible with it.