Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Account for the scroll bar size in ScrollContainerWidget objects #4569

Merged
merged 2 commits into from May 14, 2023

Conversation

ccawley2011
Copy link
Member

This currently works for ScrollContainerWidgets created using XML layouts, but not ones created using TabWidget::addTab() or OptionsContainerWidget.

Before:
scummvm-00003

After:
scummvm-00001

@sev-
Copy link
Member

sev- commented Jan 3, 2023

So far, looks proper to me

@sev- sev- marked this pull request as ready for review May 14, 2023 20:43
@sev-
Copy link
Member

sev- commented May 14, 2023

Merging this because it is already an improvement

@sev- sev- merged commit 7ef8da5 into scummvm:master May 14, 2023
@tag2015
Copy link
Contributor

tag2015 commented May 15, 2023

After this PR merge, scrollbars don't show up anymore in the Keymaps and Achievements tabs (on my windows build). Can anyone confirm?

@ccawley2011
Copy link
Member Author

After this PR merge, scrollbars don't show up anymore in the Keymaps and Achievements tabs (on my windows build). Can anyone confirm?

I haven't checked this since the PR was merged, but that was the main reason why I'd originally left this as a draft. I was hoping that someone else would be able to figure out how to get that working, but if this isn't possible in the near future it might be best to revert these changes for now. Sorry for not being more clear about the state of this PR in the initial post.

@schmurtzm
Copy link

I confirm : no more scrollbar on x86 Windows or on ARM linux.
Really annoying on handhelds which doesn't have mouse wheel to scroll 😞

@mikrosk
Copy link
Contributor

mikrosk commented Jun 19, 2023

Slightly (?) related to https://bugs.scummvm.org/ticket/14458, posting it in hope that you could look at that as well. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants