DRAGONS: Add localized hardcoded copyright screen and main menu #4589
Conversation
engines/dragons/dragons.cpp
Outdated
|
|
||
| int lastMenuItem = 1; | ||
|
|
||
| uint16 copyright[4][11][40] = { |
There was a problem hiding this comment.
You don't need to convert these to uint16, English, German and French should work fine, and the non-English characters can be escaped.
Check how other engines are handling hardcoded strings, e.g. itedata.cpp in SAGA:
https://github.com/scummvm/scummvm/blob/master/engines/saga/itedata.cpp
There was a problem hiding this comment.
Thanks for the suggestion, I already tried escaping the special characters but couldn't get it to work.
I'll look into it
There was a problem hiding this comment.
You basically write it like this:
"Blazing Dragons ist gesch\x81""tztes"
There was a problem hiding this comment.
Should be fine now :)
|
@tag2015 Perhaps, you need a helping hand with converting those strings to a more readable format? |
|
Sorry, I put this PR aside as it wasn't really urgent (also I wanted to have a look at the palette issues in the splash screen) and then I forgot about it. I'll see if I can do the changes requested |
|
@tag2015 I'd love to see it merged :D There were people asking about German version on Facebook. |
Should be ready by tomorrow! |
Also update AddAsciiText method to support special characters
tag2015
force-pushed
the
blazing_options
branch
from
2e7ce4d
to
f258797
Compare
|
Awesome! Merging. |
This PR applies the following changes to the DRAGONS engine:
Fixes bug 11696
The "spurious pixels" and text background issue 11644 will be addressed
separately