RISCOS: Use dynamic areas for data and application space for plugins #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use application space in 26-bits (legacy) mode.
lephilousophe
approved these changes
Feb 7, 2023
Since there's the issue of fragmenting the RMA and not freeing memory properly after a crash, I felt it was better to leave it out for now. I suspect that AGS is too demanding for the RiscPC anyway, so that shouldn't be too big an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up from where https://github.com/lephilousophe/scummvm/tree/riscos37 left off, and allows builds with dynamic plugins enabled to run on 26-bit versions of RISC OS. Compared to that branch, the RMA fallback has been dropped for simplicity, and dynamic detection has been disabled since it's currently not possible to unload it while engines are running.
Thanks to @lephilousophe for doing the initial work on this.