Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: Default audio output rate to 44kHz. #471

Merged
merged 2 commits into from
Jun 29, 2014

Conversation

lordhoto
Copy link
Contributor

As the title suggests this makes SDL ports use a default of 44kHz instead of 22kHz for the audio output rate. GP2X, Symbian, WinCE still use their old default values. This should increase the sound quality for games. This includes the AdLib emulator, but is probably also beneficial for Wintermute games.

For desktop ports it should be no issue to default to 44kHz. The only issue might be lower end ports derived from SDL. This includes MAEMO, Dingux, GPH (only GP2x Wiz), OpenPandora, WebOS, SamsungTV and LinuxMoto (and PS3, but I guess it should be fine). If you are a porter of any of these ports and have an opinion/objection about this change, please drop a line in here. I will wait for a week and merge this (somewhen next sunday) in case no objections have been raised by porters.

@bluegr
Copy link
Member

bluegr commented Jun 24, 2014

Looks to be a quite small and self-contained change. If there aren't any regressions (especially with the PS3 port), it looks fine

@bgK
Copy link
Member

bgK commented Jun 24, 2014

The PS3 port works fine with this change. I was even wondering whether we could go up to 48KHz, since it is the only frequency accepted by the PS3 API. Currently SDL does the conversion.

@lordhoto
Copy link
Contributor Author

I was even wondering whether we could go up to 48KHz, since it is the only frequency accepted by the PS3 API.

We could think of that. There's no real particular reason to use 44kHz instead of 48kHz. There is some bits which can be confusing to users (like the OPL emulation being sensitive to the output rate and thus comparing with DOSBox is only possible when using the same rate), but that's really really minor. I don't think that's preventing us from going to 48kHz. If you prefer 48kHz for PS3, I'll change it to that.

@lordhoto
Copy link
Contributor Author

Since there have been no objections I merge this now.

lordhoto added a commit that referenced this pull request Jun 29, 2014
SDL: Default audio output rate to 44kHz.
@lordhoto lordhoto merged commit dd4388b into scummvm:master Jun 29, 2014
@lordhoto lordhoto deleted the sdl-default-rate branch July 3, 2014 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants