PINK: Clear global game variables on New Game #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the cause for #13869 PINK: Can't pickup the poker in sir Manley's house However, this will not retroactively fix the broken saved games that carry stale global game variables from other playthroughs It will also will not set the "appropriate" global game variables if the player uses the debug console to jump to different modules and pages back and forth.
|
Seems reasonable, but need to check assembly. |
|
Nice work! |
voltya
approved these changes
Apr 27, 2023
|
Great! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the cause for #13869 PINK: Can't pickup the poker in sir Manley's house
However: