TETRAEDGE: Fix TeImage output on big-endian hosts #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccawley2011
reviewed
May 22, 2023
dwatteau
force-pushed
the
fix/tetraedge-teimage-big-endian-hosts
branch
from
6f614d0
to
4651719
Compare
|
I'm happy merging this if it fixes the rendering - although we may need to further tweak if the performance is the problem. I think this will result in some reordering happening during copying and it's possible that it could be avoided by changing some other part of the code. We can look at that separately though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix the following kind of output for the menus of Syberia on big-endian hosts.
Tested with the Macintosh release from GOG, on a PowerPC G4. Mostly tested with Syberia 2, since Syberia 1 has a very low framerate on this device, for some other reason.
Submitted as a PR, because I'm not very familiar with the game or with the proper way of dealing with
Graphics::PixelFormat. I just "stole" this from what the Grim engine does in a similar case.(Please don't close the Trac issue above, as the Theora video slowness issue is still unresolved at the moment.)