DIRECTOR: Fix WinFont scaling memory leak when scaling fonts. #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory leak happened because the scaled generated fonts were not being cached or saved anywhere, thus they were not being destructed and freed. Added logic to cache generated font in _winFontRegistry itself. Leaks observed in `trektech-win` of director engine in first few frames itself.
hari01584
force-pushed
the
winscale_mem_leak
branch
from
e40d577
to
64d935d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leak happened because the scaled generated fonts were not being cached or saved anywhere, thus they were not being destructed and freed. Added logic to cache generated font in _winFontRegistry itself.
Leaks observed in
trektech-winin first few frames itself.