Adding The Prince and the Coward #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AD_ENTRY1s("databank.ptc", "5fa03833177331214ec1354761b1d2ee", 3565031), | ||
| Common::DE_DEU, | ||
| Common::kPlatformWindows, | ||
| ADGF_NO_FLAGS, |
There was a problem hiding this comment.
This should probably contain either ADGF_UNSTABLE or ADGF_TESTING, depending on whether you want to announce the game for testing immediately after merging this PR.
Faster searching by changing switch to bsearch and array
To beconsistent and to keep just one of them
Add skipping anti-alias check for last pixel in row
Change all of READ_UINT16 to READ_LE_UINT16 and all READ_UINT32 to READ_LE_UINT32 for endian-safety
…32 to WRITE_LE_UINT32 for endian-safety fix
|
Okay, since endianness issues seem to be addressed, the rest could be performed in-tree |
sev-
added a commit
that referenced
this pull request
Oct 10, 2014
PRINCE: Adding The Prince and the Coward
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about Prince engine, which allows to handle “The Prince and the Coward” game. (http://www.mobygames.com/game/prince-and-the-coward)
The engine is developed by john_doe, malik and me. All my work was done during the GSoC 2014 project (http://lukaslwgsoc.blogspot.com/).
The game is completable in Polish, but still lacks English translation (I’m going to start working on it now.)
List of TODO’s:
• Play-through the German version
• Test game on big-endian machine
• Handle sound and music settings
• Throw a rock mini-game – sometimes after finishing a mini-game, during the last animations, bird appears in 2 places (probably glitch in script)
• Several glitches with drawing shadows may appear (need testing)
• Pathfinding - in map location, after spam clicking on unexplored location, hero can stuck and start repeating over and over: “I’d better return to known territories…”.
• Allow intro skipping
• Support loading during game start-up
• One-armed bandit mini-game - last row of skulls can be bugged if we pull the lever immediately after pressing the button third time (while the last row still slowly rotate). Bug also appears in original version of game and it doesn’t break whole mini-game.
• Bad colours of inventory’s background in „Before Fjord Castle” location. Bug also appears in original version of game.
• Broken animation of disguised woman (after giving her the poison) in Tavern location. Bug also appears in original version of game.
Please help with code reviewing, every comment is welcome.