Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Implement scroll-able type textcast member #5182

Merged
merged 8 commits into from Aug 3, 2023

Conversation

hari01584
Copy link
Contributor

Implements textType kScrollableText, which is used in books placed in the library of 'totaldistortion'. It uses MacTextWindow to render the text, which includes a scrollbar.

--start-movie="ATD\HD\bbTWRFL2.DXR@392" totaldistortion-win

@lephilousophe lephilousophe added the GSoC Part of a Google Summer of Code project label Jul 31, 2023
Win95 scrollbar loading is refactored to use existing `borders` array
in `datafiles.cpp`, Added no-border scrollbar for MacOS, Win95.

This is to support scrollable text cast members in Director, which
will be used by `totaldistortion-win` game.
--start-movie="ATD\HD\bbTWRFL2.DXR@392" totaldistortion-win
This patch implements textType kScrollableText, which is used in books
placed in the library of 'totaldistortion'. It uses MacTextWindow to
render the text, and adds a scrollbar to the window.

--start-movie="ATD\HD\bbTWRFL2.DXR@392" totaldistortion-win
This patch ensures that the `_callback` function is executed in the
MacTextWindow class.
This patch implements events for scrolltype text cast members, callbacks
in MacTextWindow is used to redirect events to director engine.

`ATD\HD\bbTWRFL2.DXR@392` of 'totaldistortion-win' uses `mouseUp` score
script attached to scrolltype text cast member, which when clicked calls
`getMouseLine` to find the clicked book, thus opening it.
This patch bumps IDs of scrollable border to 0x1000 and above, so that
they don't conflict with IDs normal borders, additionally to support this
change windowType is changed from `byte` type to `uint32` type.
@sev-
Copy link
Member

sev- commented Aug 3, 2023

Thank you!

@sev- sev- merged commit 26aa07c into scummvm:master Aug 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Part of a Google Summer of Code project
Projects
None yet
3 participants