CRAB: Add engine #5229
Merged
CRAB: Add engine #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
requested changes
Aug 10, 2023
| } | ||
|
|
||
| void scanDir() { | ||
| Common::String res = "CRAB_*"; |
There was a problem hiding this comment.
You mentioned that the savefiles are named UNREST.###. Is this a leftover, then?
| } | ||
|
|
||
| void KeyBindMenu::initMenu(const int &type) { | ||
| warning("STUB: KeyBindMenu::initMenu()"); |
There was a problem hiding this comment.
As I understand, you rely on our keymapper. Should this be cleaned up, then? Or do you plan to connect them together, so they stay in sync?
| } | ||
|
|
||
| void saveState(rapidxml::xml_document<> &doc, rapidxml::xml_node<char> *root, const char *name) { | ||
| warning("STUB: Vector2D::saveState()"); |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR integrates the CRAB engine made by Pyrodactyl Games in ScummVM, with the goal of supporting the game "Unrest" created by the same studio. Unrest is an adventure RPG that adapts to death, failure, and the choices you make.
I have tested and am able to play the game from start to end without any major issues.
The following list of things need to be improved or are missing:
Thanks!