AGS: Fix ASAN crashes in SIMD blit paths #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracturehill
force-pushed
the
simd-asan-crashes
branch
from
061732b
to
56ab233
Compare
All optimized blitting paths exhibit similar overreading behavior, due to the flawed design of (almost) always loading a full 128/256-bit line, and discarding overread pixels afterwards. This commit patches up the code so the overreads never happen, albeit at the cost of a few memcpys at the end of every line of pixels.
fracturehill
force-pushed
the
simd-asan-crashes
branch
from
56ab233
to
55d6e14
Compare
|
Tested on NEON too, and everything works as expected. Merging. Thank you for your amazing work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All optimized blitting paths exhibit similar overreading behavior, due to the flawed design of (almost) always loading a full 128/256-bit line, and discarding overread pixels afterwards. This PR patches up the code so the overreads never happen, albeit at the cost of a few memcpys at the end of every line of pixels.
The SSE2 and AVX2 paths have been tested quite well (thanks @tag2015 !), but the NEON path has not.