TETRAEDGE: Cache Resource Files #5714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of Common::FSDirectory cache of Resources folder to greatly accelerate lookup of game assets at runtime.
|
Thanks! In a release build it performed fine on MacOS so I never looked into optimizing it. I'll give this a test and merge assuming it looks god. |
|
@andrewglass Thanks again for trying to improve this. I gave your branch a try, but it seems on macOS at least to break existing game entries - they fail with: |
|
In general, what is the reason for using FSNodes like that? The conventional way would be to add the relevant directory with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TETRAEDGE: Cache Resource Files
Modify TeCore's file searching behaviour to make use of a
Common::FSDirectory cache of the games resources folder.
This greatly reduces the time spent when looking up
resources during gameplay and loading.
The original behaviour exhibited multi second long
pauses when navigating Syberia 1's main menu and
longer pauses when trying to load a saved game.
With these changes all pause is eliminated.
The pauses were observed on a Windows 10 machine
with powerful hardware (5700x cpu and nvme SSD) so
the appearance and length of them were unexpected.