TETRAEDGE: Syberia shadow rendering #5718
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TETRAEDGE: Disable rendering of walkable paths as shadows/shaded areias in Syberia
The engine renders the walkable areas of Syberia 1 as shadow or shaded areas.
This seems like it was fixed for Syberia 2 but the same issue is present in Syberia 1.
Disabling the check for Syberia 1 in the CharactersShadowOpenGL::draw call
and instead using only shadowReceivingObjects fixes this issue.
Below are screenshots of before, after and a wireframe of the mesh that was
incorrectly drawn.
The shadows are most noticable in the area around the chair and tables in the
left foreground of the scene.
Before:
![OriginalShadows](https://private-user-images.githubusercontent.com/47980168/313496105-e8f05396-b69c-4aeb-9621-c580b71db8a8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5MTIzMjIsIm5iZiI6MTcxODkxMjAyMiwicGF0aCI6Ii80Nzk4MDE2OC8zMTM0OTYxMDUtZThmMDUzOTYtYjY5Yy00YWViLTk2MjEtYzU4MGI3MWRiOGE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDE5MzM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2ZDE5Mjg3YTYzNWZlMWM2MzRlYmZmZmE5ZGViNmUzOTVlNWNlNzk1Y2NiN2I4YTczZGEwNzc3MTU0MGYyMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.n5i67UbryZw94eXFFMaK4SH5RAFVGSARn3T_kadtMVc)
![FixedNoShadows](https://private-user-images.githubusercontent.com/47980168/313496106-8ce3aa49-fce0-4bc9-8b67-80200161a113.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5MTIzMjIsIm5iZiI6MTcxODkxMjAyMiwicGF0aCI6Ii80Nzk4MDE2OC8zMTM0OTYxMDYtOGNlM2FhNDktZmNlMC00YmM5LThiNjctODAyMDAxNjFhMTEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDE5MzM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg4NWU0MjI2Y2EwOGNjMjkwOTcxNjJhYTE5ODEyNDk0MTYyMTY5OGRhNDNkMjgwZDAxYzJlZTIxMDgzMjE2ODkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aGt9rd-mqnXvaK7JRu-UpQKMfFQAzkpEzXWz0mpxJZs)
![wireframe](https://private-user-images.githubusercontent.com/47980168/313496274-38e76283-d369-4612-bc20-c04a9bb1a20c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5MTIzMjIsIm5iZiI6MTcxODkxMjAyMiwicGF0aCI6Ii80Nzk4MDE2OC8zMTM0OTYyNzQtMzhlNzYyODMtZDM2OS00NjEyLWJjMjAtYzA0YTliYjFhMjBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDE5MzM0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyZGM2ODUyYWE4MTc1Y2VlODgwMzdhNTdjNzhjZjY0OTY0ZmJmMjZjZjNjMjQ2OWIyMDY2N2ExZWRkOTAzNDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.smW4w8suBXQHMtrWXz3R80cawD4HkAAErrf-z__T3a8)
After:
Wireframe: