Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TETRAEDGE: Syberia shadow rendering #5718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewglass
Copy link

TETRAEDGE: Disable rendering of walkable paths as shadows/shaded areias in Syberia

The engine renders the walkable areas of Syberia 1 as shadow or shaded areas.
This seems like it was fixed for Syberia 2 but the same issue is present in Syberia 1.
Disabling the check for Syberia 1 in the CharactersShadowOpenGL::draw call
and instead using only shadowReceivingObjects fixes this issue.

Below are screenshots of before, after and a wireframe of the mesh that was
incorrectly drawn.
The shadows are most noticable in the area around the chair and tables in the
left foreground of the scene.

Before:
OriginalShadows
After:
FixedNoShadows
Wireframe:
wireframe

Disable rendering of walkable paths as shadows/shaded areias in Syberia
@mduggan
Copy link
Contributor

mduggan commented Mar 17, 2024

I'm not sure this is quite right - although it's probably not quite right at the moment either.

The shadowReceivingObjects are a specific object type in the Syberia 2 xml definitions, eg:

Resources/scenes/A1_Train/10020/Scene10020.xml
18:	<shadowReceivingObject name="SR10020-01"/>
19:	<shadowReceivingObject name="SR10030-01"/>

These definitions don't exist in Syberia 1's files. To correctly render the character's shadow I think you still need to draw the walk areas in the shadow pass, but there is still likely something wrong with the way they are being rendered. Feel free to correct me here though - everything I know about GL I learned by exactly copying what the original games seemed to do here..

@mduggan mduggan self-assigned this Mar 21, 2024
@mduggan
Copy link
Contributor

mduggan commented Apr 8, 2024

@andrewglass any thoughts on a way this could be fixed properly? With your change I would expect that the shadows will not appear as expected say in the street scene (where you should see the shadow blob under Kate but also an extended shadow on the road).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants