ANDROID: Remove deprecation warnings #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
force-pushed
the
android-deprecated
branch
from
707e46c
to
2c3c741
Compare
|
I just tested on API levels 29 (Q) and 19 (Kit Kat) and it works OK. |
Use ConnectivityManager instead: - it's more accurate - it has been available since API level 16 which is the minimum we require - it removes a deprecation warning
It's kind of based on Androidx but is simpler and goes up to Jelly Bean. This removes a bunch of warnings.
We don't support something like Honeycomb anymore
This allows to remove deprecation warning on a limited part of code
We expect the array to be of even size so don't add the external data title if there is no external data mount point
lephilousophe
force-pushed
the
android-deprecated
branch
from
2c3c741
to
20e318b
Compare
|
I just tested on emulated Jelly Bean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of commits which remove deprecated warnings mainly by isolating code inside its own function in a class dedicated to compatibility shims.
There is also some API changes to determine if connection is limited (metered) and to make the application immersive.
This has been tested on API level 34 (U).
I will test later on API levels 29 (Q) and 19 (Kit Kat).
I could test on 16 (Jelly Bean) with an emulator too.