BAGEL: New engine for Space Bar #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and split some assignments out of if statements
…nsecutively missing headers in other files
…subsequently missing headers in other files
…de from header to cpp file, remove unused functions
…ad of 1, add some override keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All, we were working in the background with the original sources for the Space Bar.
Here is the PR for your review and feedback.
There are very few known little problems and a bit more cleanup is required. One of the bigger remaining things is mass-renaming methods/class variables to conform to our guidelines. The formatting should be fine.
This is a joint effort. Kudos to @dreammaster, @SupSuper, and @Strangerke.