Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAPHICS: MACGUI: Improve image quality in markdown documents #5767

Merged
merged 1 commit into from
May 9, 2024

Conversation

ccawley2011
Copy link
Member

Images are now pre-scaled with bilinear filtering. The relevant code has also been split out from the rest of the MacGUI code to allow easier reuse.

Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Do you think we need to add documentation now?

public:
~ImageArchive();

void reset();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since now it is in the common code, it would be good to add Doxygen documentation here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some brief comments for the class and the public functions.

@sev-
Copy link
Member

sev- commented May 9, 2024

Thank you!

@sev- sev- merged commit 248ab4c into scummvm:master May 9, 2024
8 checks passed
@ccawley2011 ccawley2011 deleted the image-archive branch May 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants