Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: Updates the splash screens #647

Merged
merged 1 commit into from Jan 7, 2016
Merged

Conversation

bSr43
Copy link

@bSr43 bSr43 commented Jan 7, 2016

This updates the iOS media files, in order to match the official media.

@lordhoto
Copy link
Contributor

lordhoto commented Jan 7, 2016

Looks great.

Can you also make a pull request to scummvm-media with an SVG which is used to generate these files? Please make sure that the versions in this PR are what you get when using the SVG file. If you need to update the PNG files afterwards, I suggest to replace this commit. Having all these big binary blobs in git isn't too nice :-).

@bSr43
Copy link
Author

bSr43 commented Jan 7, 2016

You are right about the binary blobs :)
I'm feeling stupid, because I have thrown the SVG I used to generate the PNG. That being said, I wrote a new little Bash script which generates the SVG, and then convert them using ImageMagick. Would you be interested in this script as well? :)

@lordhoto
Copy link
Contributor

lordhoto commented Jan 7, 2016

Would you be interested in this script as well? :)

Sure, that sounds great to have in scummvm-media :-).

@lordhoto
Copy link
Contributor

lordhoto commented Jan 7, 2016

Are these files generated from scummvm-media now? If so, I'll merge this.

@bSr43
Copy link
Author

bSr43 commented Jan 7, 2016

Yes, they are!

lordhoto added a commit that referenced this pull request Jan 7, 2016
IOS: Updates the splash screens
@lordhoto lordhoto merged commit 68e9cd1 into scummvm:master Jan 7, 2016
@lordhoto
Copy link
Contributor

lordhoto commented Jan 7, 2016

Great thanks!

@bSr43 bSr43 deleted the ios-media branch January 7, 2016 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants