Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object.assign doesn't work in IE11 and breaks app #22

Closed
manuelbertelli opened this issue Mar 2, 2017 · 4 comments
Closed

Object.assign doesn't work in IE11 and breaks app #22

manuelbertelli opened this issue Mar 2, 2017 · 4 comments
Labels
bug

Comments

@manuelbertelli
Copy link

screen shot 2017-03-02 at 16 57 54

screen shot 2017-03-02 at 16 57 43
@guisouza
Copy link
Contributor

We could use : https://github.com/sindresorhus/object-assign

@guisouza guisouza added the bug label May 28, 2017
@guisouza
Copy link
Contributor

How do we proceed with this one ?
lets implement the polyfill in cases Object.assign is not available ?

@albertossilva
Copy link
Collaborator

we already have loadash installed, let's use it.

@manuelbertelli
Copy link
Author

I've tried creating a boilerplate app using create-react-app, imported speck-entity and ran in a IE10/Win7 virtual machine. Everything is working fine. I suppose the project I was working on was importing speck directly from the src folder instead of the lib, that's why the error occured. So, this issue can be closed.

Chrome
screen shot 2017-06-30 at 14 17 29

IE11
screen shot 2017-06-30 at 14 32 19

IE10
screen shot 2017-06-30 at 14 17 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manuelbertelli @albertossilva @guisouza