Missing .raw attribute should raise proper exception

[gokceneraslan]

Hey,

adata = sc.datasets.paul15()
adata._get_obs_array('Sfpi1', use_raw=True)

raises ValueError: Did not find Sfpi1 in obs.keys or var_names. However the correct exception should be ".raw doesn't exist" or so.

How I ended up with this was actually sc.pl.scatter(adata, 'Sfpi1', 'Gata1'), which raises the same exception. Raising an exception explicitly about the lack of .raw would be much more informative for users.

I guess @Koncopd added the layer support, so he might be interested.

[Koncopd]

Added this 4148828

I also believe that it should be use_raw=False (not it is True) as the default option in scatter...

[falexwolf]

The default option in sc.pl.scatter should be use_raw=None which defaults to looking up .raw if it exists and not looking it up otherwise. This is indeed the current behaviour even though the default is use_raw=True. I can easily change this, I think, without breaking anything. So I'll go ahead and do it.

[falexwolf]

This would be the corresponding commit: scverse/scanpy@9a7c0a9

[gokceneraslan]

Cool! That makes a lot of sense...

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[flying-sheep]

this is fixed