Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDR3 convergence #23

Closed
grst opened this issue Apr 9, 2020 · 7 comments · Fixed by #168
Closed

CDR3 convergence #23

grst opened this issue Apr 9, 2020 · 7 comments · Fixed by #168

Comments

@grst
Copy link
Collaborator

grst commented Apr 9, 2020

In GitLab by @szabogtamas on Feb 11, 2020, 16:00

I think we need to think again about how to compute the convergence and how useful it is in the context of single cell data.
In our example dataset, it appears so occur at negligible rates and doesn't make sense to be visualized as a barplot.
Finally, I believe it measures something similar as TCR-dist.

Ideas:

  • Create a single value measure (like singlet rate).
  • Rather show on UMAP than as bar plot?

The CDR3 convergence is currently hidden from the public API, but the preliminary code is still in _plotting._cdr_convergence.

@grst grst added this to the plot overhaul milestone Apr 9, 2020
@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 16, 2020, 15:20

changed title from {-CDR3 convergence as a single measur-}e to {+Refactor CDR3 convergenc+}e

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 16, 2020, 15:20

changed the description

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 16, 2020, 15:28

In any case, it can be computed with tl.clip_and_count - no additional tool needed.

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Mar 20, 2020, 18:15

changed title from {-Refactor -}CDR3 convergence to CDR3 convergence

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Apr 6, 2020, 20:08

In any case, it can be computed with tl.clip_and_count - no additional tool needed.

not sure if this is actually true...

Anyway, to some extent this is now possible by comparing the clonotype definitions based on nucleotides and amino acids.
Could still be wrapped in a nice tool.

I still need to think, though, if it's best to rely on the clonotype-definitions for that or do it independently of that.

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @szabogtamas on Apr 7, 2020, 09:36

Maybe we could offer a tool that accepts a pair of clonotype definitions (nt-based and aa-based by default) and returns the convergence from the first to the second. The user could then choose to use it as a measure of convergence of nts to aas or aas to alignment-based groups. I would not make it independent of the clonotype definition tool.

@grst
Copy link
Collaborator Author

grst commented Apr 9, 2020

In GitLab by @grst on Apr 7, 2020, 09:43

that's a great idea! way more flexible and also allows e.g. to compare
alignment to identity

@grst grst added this to prio2 in scirpy-dev Apr 9, 2020
@grst grst removed the future label Apr 9, 2020
@grst grst removed this from the plot overhaul milestone Apr 15, 2020
@grst grst moved this from prio2 to ToDo in scirpy-dev May 6, 2020
@grst grst moved this from ToDo to prio2 in scirpy-dev May 19, 2020
@grst grst moved this from prio2 to ToDo in scirpy-dev May 19, 2020
@grst grst moved this from ToDo to prio2 in scirpy-dev May 30, 2020
@grst grst moved this from prio2 to ToDo in scirpy-dev Jun 23, 2020
@grst grst moved this from ToDo to In progress in scirpy-dev Aug 3, 2020
@grst grst closed this as completed in #168 Aug 3, 2020
scirpy-dev automation moved this from In progress to Done Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
scirpy-dev
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant