gemini: attempts to shutdown more precisely #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'golang.org/x/sync/errgroup' instead of Tomb. Simplifying the nested goroutines and returns errors more frequently.
dahankzter
force-pushed
the
issue_226
branch
2 times, most recently
from
ac839c5
to
2b8817b
Compare
The main run method now executes jobs directly and runs warmup synchronously if needed. Signal handling moved out to the main run method instead of being piggybacked on the pump.
This was referenced May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 'golang.org/x/sync/errgroup' instead of Tomb. Simplifying
the nested goroutines and returns errors more frequently.
Fixes: #226