Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure go data migrations require empty cql file #101

Closed
ajankovic opened this issue May 9, 2019 · 1 comment · Fixed by #178
Closed

Pure go data migrations require empty cql file #101

ajankovic opened this issue May 9, 2019 · 1 comment · Fixed by #178

Comments

@ajankovic
Copy link
Contributor

ajankovic commented May 9, 2019 •
edited

CQL files are needed to create migrations. In situations where go migration code is needed to create data only migrations, CQL file becomes superficial.

Workaround for this is to use empty file and attach go code execution as callback. But empty CQL file is not accepted so workaround for this is to use some read only statement in the CQL file to make sure go callback is executed.

This all feel kinda hackish and should probably be given consideration in the future.
@mmatczuk mmatczuk added this to the 2.0 milestone Nov 7, 2019
@mmatczuk mmatczuk removed this from the 1.5 milestone Apr 22, 2020
@mmatczuk
Copy link
Contributor

https://flywaydb.org/documentation/migrations#java-based-migrations

mmatczuk added a commit that referenced this issue Dec 2, 2020
@mmatczuk
migrate: Add support for Go code migrations in the middle of processi…
7d0efc7 
…ng a CQL file

This patch adds a new migration event type InMigration that it triggered by adding `-- DO <name>;` comment in a CQL file.

Fixes #101
@mmatczuk mmatczuk mentioned this issue Dec 2, 2020
Merged
mmatczuk added a commit that referenced this issue Dec 2, 2020
@mmatczuk
migrate: Add support for Go code migrations in the middle of processi…
4782809 
…ng a CQL file

This patch adds a new migration event type InMigration that it triggered by adding `-- DO <name>;` comment in a CQL file.

Fixes #101
mmatczuk added a commit that referenced this issue Dec 3, 2020
@mmatczuk
migrate: Add support for Go code migrations in the middle of processi…
6cf4101 
…ng a CQL file

This patch adds a new migration event type InMigration that it triggered by adding `-- CALL <name>;` comment in a CQL file.

Fixes #101
mmatczuk added a commit that referenced this issue Dec 3, 2020
@mmatczuk
migrate: Add support CQL comment callbacks
bdbbe2e 
This patch adds a new migration event type CallComment that it triggered by adding `-- CALL <name>;` comment in a CQL file.

Fixes #101
mmatczuk added a commit that referenced this issue Dec 3, 2020
@mmatczuk
migrate: Add support CQL comment callbacks
3e419d9 
This patch adds a new migration event type CallComment that it triggered by adding `-- CALL <name>;` comment in a CQL file.

Fixes #101
mmatczuk added a commit that referenced this issue Dec 3, 2020
@mmatczuk
migrate: Add support CQL comment callbacks
d25129e 
This patch adds a new migration event type CallComment that it triggered by adding `-- CALL <name>;` comment in a CQL file.

Fixes #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate: Add support for Go code migrations in the middle of processing a CQL file scylladb/gocqlx
2 participants
@ajankovic @mmatczuk