Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qb: add named limit and per partition limit clauses #208

Merged
merged 1 commit into from
Nov 23, 2021
Merged

qb: add named limit and per partition limit clauses #208

merged 1 commit into from
Nov 23, 2021

Conversation

N1cOs
Copy link
Contributor

@N1cOs N1cOs commented Nov 20, 2021

Resolve #191

@N1cOs N1cOs force-pushed the qb/limit_named branch 2 times, most recently from eae6624 to 76439b4 Compare November 21, 2021 10:56
@mmatczuk
Copy link
Contributor

Besides the new test cases what is the benefit of this change.

@N1cOs
Copy link
Contributor Author

N1cOs commented Nov 23, 2021

Besides the new test cases what is the benefit of this change.

What do you mean? I added two new methods: LimitNamed and LimitPerPartitionNamed. It resolves issue #191 and my duplicate issue #207

@mmatczuk
Copy link
Contributor

That's fine.

@mmatczuk mmatczuk merged commit beeab60 into scylladb:master Nov 23, 2021
@mmatczuk
Copy link
Contributor

Thanks.

@N1cOs N1cOs deleted the qb/limit_named branch November 23, 2021 10:49
@N1cOs
Copy link
Contributor Author

N1cOs commented Nov 23, 2021

By the way I also fixed the problem that PER PARTITION LIMIT clause must be before the LIMIT clause

@mmatczuk
Copy link
Contributor

That's excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add named limit to QueryBuilder
2 participants
@N1cOs @mmatczuk