Skip to content

Commit

Permalink
Remove clirr workaround
Browse files Browse the repository at this point in the history
The workaround that was previously required to make clirr happy
now seems to make it unhappy instead. Removing the workaround
results in another clirr issue that I added to ignore list.
  • Loading branch information
Lorak-mmk authored and Piotr Grabowski committed Jul 7, 2023
1 parent 37d85af commit f54ec8c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 6 additions & 0 deletions clirr-ignores.xml
Original file line number Diff line number Diff line change
Expand Up @@ -403,4 +403,10 @@
<to>*com.datastax.driver.core.EndPoint*</to>
<justification>JAVA-2355: Abstract connection information into new EndPoint type for sni support</justification>
</difference>
<difference>
<differenceType>7002</differenceType> <!-- method removed -->
<className>com/datastax/driver/core/ResultSet</className>
<method>*one*</method>
<justification>False positive. Method is still present in parent interface (and was only introduced in ResultSet as a workaround for another clirr false positive)</justification>
</difference>
</differences>
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
*/
public interface ResultSet extends PagingIterable<ResultSet, Row> {

// redeclared only to make clirr happy
@Override
Row one();

/**
* Returns the columns returned in this ResultSet.
*
Expand Down

0 comments on commit f54ec8c

Please sign in to comment.