Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(multi-az): adapt provision step to multi-az #6055

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

soyacz
Copy link
Contributor

@soyacz soyacz commented Apr 20, 2023

Currently provision step is disabled in pipeline when using multi-az
because it is not supporting this feature.

Adapt AWS provision to support multi-az and enable back provision step.

refs: https://github.com/scylladb/qa-tasks/issues/1070

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

@soyacz
Copy link
Contributor Author

soyacz commented Apr 20, 2023

@soyacz soyacz added test-provision-aws Run provision test on AWS backport/5.0 Need backport to 5.0 backport/2023.1 Need to backport to 2023.1 labels Apr 20, 2023
Currently we aim to test symmetrical clusters and it's easy to make
mistake in multi-az tests when number of db nodes don't divide by number
of az's.

Add additional check in sct-config to verify that.
Currently provision step is disabled in pipeline when using multi-az
because it is not supporting this feature.

Adapt AWS provision to support multi-az and enable back provision step.
@soyacz soyacz force-pushed the multi-az-provision-step-aws branch from fe139cf to 05824a9 Compare April 20, 2023 12:58
@soyacz
Copy link
Contributor Author

soyacz commented Apr 20, 2023

@soyacz
Copy link
Contributor Author

soyacz commented Apr 20, 2023

all tests executed in jobs looks ok.
As to pipeline, recently we always get Failed to get spot instances: price-too-low can we do smthing about it?

@fruch
Copy link
Contributor

fruch commented Apr 20, 2023

all tests executed in jobs looks ok. As to pipeline, recently we always get Failed to get spot instances: price-too-low can we do smthing about it?

we cloud a pipeline parameter for enabling on_demand

so we can rerun the CI with on_demend when needed

@fruch
Copy link
Contributor

fruch commented Apr 20, 2023

provision test are longevity, but without all the exposed pipeline parameters

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch added backport/5.2 Need backport to 5.2 and removed backport/5.0 Need backport to 5.0 labels Apr 23, 2023
@fruch fruch merged commit 38b7b3e into scylladb:master Apr 24, 2023
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request May 18, 2023
Recently was added check for the numbers of AZs and DB nodes [1].
The K8S backends are different and specifically EKS one requires
at least 2 AZs to be configured.
Only the first AZ will be used for node provisioning.
So, knowing that, skip the AZ num check on K8S backends.

[1] scylladb#6055
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request May 18, 2023
Recently was added check for the numbers of AZs and DB nodes [1].
The K8S backends are different and specifically EKS one requires
at least 2 AZs to be configured.
Only the first AZ will be used for node provisioning.
So, knowing that, skip the AZ num check on K8S backends.

[1] scylladb#6055
fruch pushed a commit that referenced this pull request May 18, 2023
Recently was added check for the numbers of AZs and DB nodes [1].
The K8S backends are different and specifically EKS one requires
at least 2 AZs to be configured.
Only the first AZ will be used for node provisioning.
So, knowing that, skip the AZ num check on K8S backends.

[1] #6055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.2 Need backport to 5.2 backport/2023.1 Need to backport to 2023.1 test-provision-aws Run provision test on AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants