Improved Go version of Part 2 #106
Conversation
This is a complete transliteration of the Java code but more or less idiomatic Go and driver config to enable shard awareness.
Slightly modified and with an asciiart twist.
This version uses github.com/scylladb/gocqlx to make the code much more clean and readable.
|
@dahankzter who can help with a review? |
|
Any of the Go programmers but ideally Michal.
It's very simple though and much nicer than the raw examples in the earlier
versions.
…On Thu, 12 Dec 2019, 12:55 Tzach Livyatan, ***@***.***> wrote:
@dahankzter <https://github.com/dahankzter> who can help with a review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#106?email_source=notifications&email_token=AABJYU5SQACFRBDWSTEZOALQYIRENA5CNFSM4JZ4I4Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGWNY4Q#issuecomment-564976754>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJYU6RX77JLKDGILY3DF3QYIRENANCNFSM4JZ4I4QQ>
.
|
|
|
||
| import ( | ||
| "goapp/internal/log" | ||
| "goapp/internal/scylla" |
There was a problem hiding this comment.
Internal packages for the module.
| "github.com/scylladb/gocqlx" | ||
| "github.com/scylladb/gocqlx/qb" | ||
| "github.com/scylladb/gocqlx/table" | ||
| "go.uber.org/zap" |
There was a problem hiding this comment.
hmm... Let me check.
There was a problem hiding this comment.
Zap is the logger. The other import just defines a helper method to create the otherwise quite verbose setup of the zap logger.
Perhaps we should use golog?
mms/go/cmd/gocqlxapp/main.go
Outdated
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
I'd suggest to delete this group and use :=
There was a problem hiding this comment.
They are contained in a separate little helper struct now.
mms/go/cmd/gocqlxapp/main.go
Outdated
| PictureLocation string `db:"picture_location"` | ||
| } | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
Init is a bad practice. Use struct instead
There was a problem hiding this comment.
Why is it bad for main apps?
There was a problem hiding this comment.
Removed init for specific global assignment.
| } | ||
| } | ||
|
|
||
| func insertQuery(session *gocql.Session, firstName, lastName, address, pictureLocation string, logger *zap.Logger) { |
There was a problem hiding this comment.
Passing all those params and building the Record is strange
There was a problem hiding this comment.
Yes, I kept it for similarities with the other examples.
|
@tzach please merge |
This uses
github.com/scylladb/gocqlxto create a much nicer developer experiencewith clear and safe code.