Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding code for cpp lesson part 2 #137

Merged
merged 1 commit into from
Jul 5, 2020
Merged

adding code for cpp lesson part 2 #137

merged 1 commit into from
Jul 5, 2020

Conversation

guy9
Copy link
Collaborator

@guy9 guy9 commented Jul 3, 2020

@@ -10,7 +10,7 @@ int main(int argc, char* argv[]) {

// Add the contact points. These can be either IPs or domain names.
// You can specify more than one, comma-separated, but you don’t have to - driver will discover other nodes by itself. You should do it if you expect some of your contact points to be down.
cass_cluster_set_contact_points(cluster, "172.21.0.2"); // set the IP according to your setup
cass_cluster_set_contact_points(cluster, "172.18.0.2"); // set the IP according to your setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems random
If the IP change on every run, why change it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not very important. In the lesson (and in the code comments above) the instructions tell the user to change the IP according to their cluster.
I wanted it to be the same in Part 1 and Part 2 but it would be changed by the user anyhow so it doesn't matter much.

@tzach tzach merged commit f70370a into scylladb:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants