Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MMS app in Scala #144

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Add MMS app in Scala #144

merged 1 commit into from
Sep 16, 2020

Conversation

iravid
Copy link
Contributor

@iravid iravid commented Sep 14, 2020

No description provided.

@guy9
Copy link
Collaborator

guy9 commented Sep 15, 2020

@penberg please review

penberg
penberg approved these changes Sep 15, 2020
View reviewed changes
Copy link

@penberg penberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a long time since I last wrote any Scala code, but from what I can see, this looks like nice and clean idiomatic Scala.

mms/scala/README.md
```

### To manually add the catalog keyspace and data
docker exec -it mms_scylla-node1_1 cqlsh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triple ticks (```)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard markdown

Standard markdown

Try it for yourself in the following comment ;)

@tzach tzach merged commit 62c7c69 into scylladb:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzach tzach tzach left review comments

@penberg penberg penberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iravid @guy9 @penberg @tzach