Fix check gossiper generation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vladzcloudius
commented
Feb 8, 2021
vladzcloudius
commented
- Remove the dependency on the scylla.yaml contents.
- Check all cluster's nodes at once.
- Add the framework to provide parameters.
The script was pretty bogus as to requirements on the contents of scylla.yaml. Instead of trying to fix the above I simply rewrote it to check all nodes at once. Signed-off-by: Vlad Zolotarov <vladz@scylladb.com>
Signed-off-by: Vlad Zolotarov <vladz@scylladb.com>
* Calculate 'now' once instead of re-doing it in a loop. * Take the 'YEAR' assignment outside the loop too Signed-off-by: Vlad Zolotarov <vladz@scylladb.com>
|
@tarzanek Could you, please, review? |
tarzanek
reviewed
Feb 9, 2021
|
|
||
| set -e | ||
| usage() { | ||
| cat $0 | grep "^# !" | cut -d"!" -f2- |
There was a problem hiding this comment.
wouldn't it be easier just to echo the single line? ;-)
but this works too, so just nitpicking
tarzanek
approved these changes
Feb 9, 2021
|
merging, thnx Vlad |
This was referenced Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.