Support for general binding and parsing any types #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for binding any type with use of gocql.Marshal - Added support for scanning any type with use of gocql.Unmarshal - Binding to unprepared queries can now be done only with type-specialized methods - Incorrect binding will now return an error on query execution - Added a benchmark comparing conversions using general and concrete methods, results: goos: linux goarch: amd64 pkg: github.com/mmatczuk/scylla-go-driver cpu: 11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz BenchmarkBindConcrete-16 241682629 5.023 ns/op 0 B/op 0 allocs/op BenchmarkBindAny-16 29523056 39.13 ns/op 15 B/op 1 allocs/op BenchmarkAsConcrete-16 511050747 2.350 ns/op 0 B/op 0 allocs/op BenchmarkAsAny-16 52738100 21.69 ns/op 8 B/op 1 allocs/op PASS ok github.com/mmatczuk/scylla-go-driver 5.528s Fixes #121 Fixes #123 Fixes #158
Kulezi
changed the title
|
This will be used in a separate package providing gocql compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will be needed to make a compatibility layer for gocql and gocqlX, benchmarks show that it's much slower than concrete bindings, however I can barely see any difference with
make run-benchtab, maybe because of the driver having spare time due to waiting on syscalls.