New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure "Resource Disk" support for swapfile is broken #431
Labels
Comments
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 30, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#431
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 30, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#431
This was referenced Jan 30, 2023
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 30, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#428 Fixes scylladb#431
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 31, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#428 Fixes scylladb#431
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 31, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#428 Fixes scylladb#431
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 31, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#428 Fixes scylladb#431
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 31, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#428 Fixes scylladb#431
syuu1228
added a commit
to syuu1228/scylla-machine-image
that referenced
this issue
Jan 31, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes scylladb#428 Fixes scylladb#431
yaronkaikov
pushed a commit
that referenced
this issue
Feb 1, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes #428 Fixes #431
yaronkaikov
pushed a commit
that referenced
this issue
Feb 2, 2023
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time. So e7e7daa was incorrect, we currently mistakenly using rootfs for swapfile. We need to allocate it on instance startup time, not machine image building time. And also it should executed after "Resource Disk" mounted to /mnt. Fixes #428 Fixes #431 (cherry picked from commit a473779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since "Resource Disk" is ephemeral, we cannot configure swapfile on machine image building time.
So e7e7daa is incorrect, we currently mistakenly using rootfs for swapfile.
(It looks correct since the file path is /mnt/swapfile, but it was created before mounting /mnt so it actually on rootfs)
We have to setup it on scylla_image_setup (= instance startup time), not scylla_install_image (= machine image building time).
The text was updated successfully, but these errors were encountered: