Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packer: increase pause_before value and add ssh_read_write_timeout #461

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

benipeled
Copy link
Contributor

After adding the pause_before param on db75e41 I saw that we have SSH connection issues, so in this PR I'm increasing the pause to 20s and adding the ssh_read_write_timeout param

Example failure:

10:08:16  �[1;32m==> aws: Pausing 10s before the next provisioner...�[0m
10:08:27  �[1;32m==> aws: Uploading files/ => /home/ubuntu/�[0m
10:08:30  �[1;31m==> aws: Upload failed: dial tcp 54.198.229.78:22: connect: connection refused�[0m
10:08:30  �[1;32m==> aws: Provisioning step had errors: Running the cleanup provisioner, if present...�[0m
10:08:30  �[1;32m==> aws: Terminating the source AWS instance...�[0m
10:09:36  �[1;32m==> aws: Cleaning up any extra volumes...�[0m
10:09:36  �[1;32m==> aws: No volumes to clean up, skipping�[0m
10:09:36  �[1;32m==> aws: Deleting temporary keypair...�[0m
10:09:36  �[1;31mBuild 'aws' errored after 2 minutes 23 seconds: dial tcp 54.198.229.78:22: connect: connection refused�[0m
10:09:36  
10:09:36  ==> Wait completed after 2 minutes 23 seconds
10:09:36  
10:09:36  ==> Some builds didn't complete successfully and had errors:
10:09:36  --> aws: dial tcp 54.198.229.78:22: connect: connection refused
10:09:36  
10:09:36  ==> Builds finished but no artifacts were created.

Following db75e41, we need to add ssh_read_write_timeout and increase
the pause_before to 20s
@benipeled
Copy link
Contributor Author

Verified twice

12:37:42  �[1;32m==> gce: Pausing 20s before the next provisioner...�[0m
12:38:02  �[1;32m==> gce: Uploading files/ => /home/ubuntu/�[0m
12:38:02  �[1;32m==> gce: Uploading scylla_install_image => /home/ubuntu/�[0m
12:38:03  �[1;32m==> gce: Provisioning with shell script: /tmp/packer-shell1237633713�[0m
12:38:04  �[0;32m    gce:�[0m
12:38:04  �[0;32m    gce: status: done�[0m
12:40:30  �[1;32m==> azure: Pausing 20s before the next provisioner...�[0m
12:40:42  �[1;32m==> azure: Uploading files/ => /home/azureuser/�[0m
12:40:42  �[1;32m==> azure: Uploading scylla_install_image => /home/azureuser/�[0m
12:40:42  �[1;32m==> azure: Provisioning with shell script: /tmp/packer-shell235878628�[0m
12:40:43  �[0;32m    azure:�[0m
12:40:43  �[0;32m    azure: status: done�[0m
12:39:09  �[1;32m==> aws: Pausing 20s before the next provisioner...�[0m
12:39:26  �[1;32m==> aws: Uploading files/ => /home/ubuntu/�[0m
12:39:26  �[1;32m==> aws: Uploading scylla_install_image => /home/ubuntu/�[0m
12:39:27  �[1;32m==> aws: Provisioning with shell script: /tmp/packer-shell2228372284�[0m
12:39:28  �[0;32m    aws:�[0m
12:39:28  �[0;32m    aws: status: done�[0m

@benipeled benipeled merged commit 94dd154 into scylladb:next Jun 21, 2023
1 check passed
@benipeled benipeled deleted the packer_2 branch June 21, 2023 09:58
@@ -100,6 +101,7 @@
"source_image_family": "{{user `source_image_family`}}",
"ssh_username": "{{user `ssh_username`}}",
"ssh_timeout": "6m",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "ssh_timeout" for gce only set to "6m"? Is there any reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea probably to increase the default

@@ -136,6 +138,8 @@
"name": "azure",
"type": "azure-arm",
"ssh_username": "{{user `ssh_username`}}",
"ssh_timeout": "5m",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the default for ssh_timeout is 5m (accoding to the doc), do we really need to add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with other providers
You're right we can remove it from all (if 5m is enough) - on the next change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants