[images] add https prefix to url #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the change made in scylladb/scylla-pkg#3764. the redirect change is now failing our image build process with the following error: ``` 02:25:02 + bash -c 'set -o pipefail; /jenkins/workspace/scylla-master/ami/scylla-pkg/tools/packaging/dpackager -e AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY -e AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID -- ./build_image.sh --target aws --product scylla --repo downloads.scylladb.com/unstable/scylla/master/deb/unified/2024-03-05T21:07:35Z/scylladb-master/scylla.list --arch x86_64 --build-mode release --ami-regions us-west-2,eu-west-2,eu-west-1,eu-central-1,eu-north-1 --ami-users 797456418907 --log-file ami_x86_64.log --build-id 1352 --build-tag jenkins-scylla-master-ami-1352 --branch master --scylla-build-sha-id ea47a2cee91392101f5630409c7650b307498e5e ' 02:25:02 5.5.0-dev-20240306.6e92623 02:25:02 --target parameter TARGET: |aws| 02:25:02 --product parameter: PRODUCT |scylla| 02:25:02 --repo parameter: REPO_FOR_INSTALL downloads.scylladb.com/unstable/scylla/master/deb/unified/2024-03-05T21:07:35Z/scylladb-master/scylla.list 02:25:02 --ami-regions parameter: AMI_REGIONS |us-west-2,eu-west-2,eu-west-1,eu-central-1,eu-north-1| 02:25:02 --ami-users parameter: AMI_USERS |797456418907| 02:25:02 --log-file parameter: PACKER_LOG_PATH |ami_x86_64.log| 02:25:02 --build-id parameter: BUILD_ID |1352| 02:25:02 --build-tag parameter: BUILD_TAG |jenkins-scylla-master-ami-1352| 02:25:02 --branch parameter: BRANCH |master| 02:25:02 --build-id parameter: SCYLLA_BUILD_SHA_ID |ea47a2cee91392101f5630409c7650b307498e5e| 02:25:02 INSTALL_ARGS: | --repo downloads.scylladb.com/unstable/scylla/master/deb/unified/2024-03-05T21:07:35Z/scylladb-master/scylla.list --product scylla| 02:25:02 Importing apt key (d0a112e067426ab2 491c93b9de7496a7) 02:25:02 gpg: keybox '/etc/apt/keyrings/scylladb.gpg' created 02:25:03 gpg: /tmp/trustdb.gpg: trustdb created 02:25:03 gpg: key 491C93B9DE7496A7: public key "ScyllaDB Package Signing Key 2024 <security@scylladb.com>" imported 02:25:03 gpg: key D0A112E067426AB2: public key "ScyllaDB Package Signing Key 2022 <security@scylladb.com>" imported 02:25:03 gpg: Total number processed: 2 02:25:03 gpg: imported: 2 02:25:03 E: Malformed line 1 in source list /etc/apt/sources.list.d/tmp.0uavludx5L.list (type) 02:25:03 E: The list of sources could not be read. ``` Fixing it following this change, scylladb/scylla-pkg#3887 and scylladb/scylla-pkg#3896 will be reverted
yaronkaikov
force-pushed
the
https_redirection
branch
from
d86aa28
to
2d238b7
Compare
benipeled
approved these changes
Mar 7, 2024
Annamikhlin
approved these changes
Mar 7, 2024
yaronkaikov
commented
Mar 7, 2024
| @@ -56,7 +56,7 @@ while [ $# -gt 0 ]; do | |||
| "--repo") | |||
| REPO_FOR_INSTALL=$2 | |||
There was a problem hiding this comment.
I forgot to commit also change in this line, it is now REPO_FOR_INSTALL="https://$2"
i added it directly to next since it was failing next-machine-image
yaronkaikov
added
backport/2023.1-done
backport/2024.1-done
backport/2022.2-done
and removed
backport/2022.2
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the change made in https://github.com/scylladb/scylla-pkg/issues/3764. the redirect change
is now failing our image build process with the following error:
Fixing it
following this change, https://github.com/scylladb/scylla-pkg/pull/3887 and https://github.com/scylladb/scylla-pkg/pull/3896 will be reverted