Mount separated /tmp, /var/tmp partition with noexec, nodev, nosuid options #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that why this PR does not use tmpfs for /var/tmp is, since applications may expected temporary files on /var/tmp should be preserved between reboots (reference: https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard). |
|
And this is part of: https://github.com/scylladb/scylla-pkg/issues/2953 |
Mount tmpfs for /tmp and apply noexec, nodev, nosuid options. This will apply following CIS compliance rules: - xccdf_org.ssgproject.content_rule_partition_for_tmp - xccdf_org.ssgproject.content_rule_mount_option_tmp_nodev - xccdf_org.ssgproject.content_rule_mount_option_tmp_noexec - xccdf_org.ssgproject.content_rule_mount_option_tmp_nosuid Fixes scylladb/scylla-enterprise-machine-image#69 Related scylladb/scylla-pkg#2953
Mount ext4 for /var/tmp and apply noexec, nodev, nosuid options. Since it's difficult to add separated partition on machine-image, it will add 1GB loopback image on /vartmpfile, just like /swapfile. To setup the file, added scylla_var_tmp_setup which is modified version of scylla_swap_setup. This will apply following CIS compliance rules: - xccdf_org.ssgproject.content_rule_mount_option_var_tmp_nodev - xccdf_org.ssgproject.content_rule_mount_option_var_tmp_noexec - xccdf_org.ssgproject.content_rule_mount_option_var_tmp_nosuid Fixes scylladb/scylla-enterprise-machine-image#69 Related scylladb/scylla-pkg#2953
|
BTW, the issue is opened at enterprise version, should we move this to enterprise? Or it's fine to merge OSS version? |
|
Need to move this to scylla-enterprise-machine-image, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount separated /tmp, /var/tmp partition with apply noexec, nodev, nosuid options.
For /tmp it will use tmpfs.
For /var/tmp, since it's difficult to add separated partition on machine-image,
it will add 1GB loopback image on /vartmpfile, just like /swapfile.
To setup the file, added scylla_var_tmp_setup which is modified version
of scylla_swap_setup.
This will apply following CIS compliance rules:
Fixes scylladb/scylla-enterprise-machine-image#69
Related https://github.com/scylladb/scylla-pkg/issues/2953